Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Announcement bar color wasn't using color from theming variables #9367

Merged
merged 2 commits into from
Mar 7, 2018
Merged

[NEW] Announcement bar color wasn't using color from theming variables #9367

merged 2 commits into from
Mar 7, 2018

Conversation

cyclops24
Copy link
Contributor

This PR read color and background-color for announcement-bar from color setting.

@rodrigok
Copy link
Member

@cyclops24 could you post screen shots of what it looks before and now?

Thanks

@cyclops24
Copy link
Contributor Author

@rodrigok Before we can't change announcement-bar style from admin and color's setting but now we can do in by change Admin > Layout > Old Colors > Primary Background Color (for background-color) and Admin > Layout > Colors > Content (for color).

For example before:
01
And now:
02

@rodrigok
Copy link
Member

So, the idea is to keep the primary base color to the announcement bar? @karlprieb @ggazzo what do you think?

@cyclops24
Copy link
Contributor Author

cyclops24 commented Jan 19, 2018 •
edited
Loading

Yes @rodrigok I think it's better. What do you think guys?

/CC: @rodrigok , @karlprieb , @ggazzo

@engelgabriel engelgabriel added this to Desirable in 0.62.0 via automation Jan 30, 2018
@engelgabriel engelgabriel added this to the 0.62.0 milestone Jan 30, 2018
@theorenck theorenck moved this from Desirable to Backlog in 0.62.0 Jan 30, 2018
@karlprieb karlprieb moved this from Backlog to To Do in 0.62.0 Feb 7, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9367 February 15, 2018 14:49 Inactive
@karlprieb karlprieb moved this from To Do to In progress in 0.62.0 Feb 20, 2018
@theorenck theorenck added this to Desireable in 0.63.0 via automation Feb 28, 2018
@theorenck theorenck modified the milestones: 0.62.0, 0.63.0 Feb 28, 2018
@theorenck theorenck removed this from In progress in 0.62.0 Feb 28, 2018
@theorenck theorenck moved this from Desireable to Backlog in 0.63.0 Feb 28, 2018
@karlprieb karlprieb moved this from Backlog to Review/QA in 0.63.0 Mar 6, 2018
@rodrigok rodrigok changed the title [NEW] fix-announcement-bar-color [NEW] Announcement bar color wasn't using color from theming variables Mar 7, 2018
@rodrigok rodrigok merged commit da60d86 into RocketChat:develop Mar 7, 2018
0.63.0 automation moved this from Review/QA to Done Mar 7, 2018
@rodrigok rodrigok mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlprieb karlprieb karlprieb approved these changes

Assignees

@karlprieb karlprieb

Labels
None yet
Projects
No open projects
0.63.0
  
Done
Milestone
0.63.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cyclops24 @rodrigok @karlprieb @engelgabriel @theorenck @BabakScript